-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
qxlsx/1.4.3: Add qt6 compatibility #11364
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
recipes/qxlsx/all/conanfile.py
Outdated
cmake.configure() | ||
return cmake | ||
|
||
def build(self): | ||
for patch in self.conan_data.get("patches", {}).get(self.version, []): | ||
tools.patch(**patch) | ||
tools.replace_in_file(os.path.join(self._source_subfolder, "QXlsx", "CMakeLists.txt"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could this be option, only if qt6 set the the required cxxstd? would be a fun surprise for qt5 consumers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done here: 7984922.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry the commit had to be fixed here: 329ec4c
@@ -8,4 +8,4 @@ find_package(QXlsx REQUIRED CONFIG) | |||
|
|||
add_executable(${PROJECT_NAME} test_package.cpp) | |||
target_link_libraries(${PROJECT_NAME} QXlsx::Core) | |||
set_property(TARGET ${PROJECT_NAME} PROPERTY CXX_STANDARD 11) | |||
set_property(TARGET ${PROJECT_NAME} PROPERTY CXX_STANDARD 17) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@prince-chrismc How shall I handle the C++ version conditionnally here ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this is the test packge, it's prefect
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@SpaceIm Is the patch submitted upstream wrong ? QtExcel/QXlsx#223 |
This comment has been minimized.
This comment has been minimized.
I like to build with C++20, and apparently there can be some issues mixing different C++ standards between libs (I forget the details). I think in the QT recipe, it uses validate() method to ensure the C++ is at least c++17, and then it is up the profile how far to push the standard. Then cmake should use the C++xx standard requested by the profile/conan. |
This comment has been minimized.
This comment has been minimized.
@jgsogo Any idea why the package is not built here ? |
@MartinDelille please, read the log exposed by the CI result on the comment above. It says:
So it says two of your requirements want to the same package, but different versions. Conan does not solve this kind of conflict, because it may result in runtime error, if those versions are incompatible. More information: https://docs.conan.io/en/latest/versioning/introduction.html#version-and-configuration-conflicts There are some ways to solve it:
The second option is bad, because qxlsx does not need freetype, which would create a fake dependency. I suggest your opening a PR for Qt package and update their dependencies first, so your error will be fixed. |
@MartinDelille good news, the PR #11853 has your fix! Just need to be merged. Thanks to @ericLemanissier |
@MartinDelille Sorry, that PR is only related to Qt 6. You need Qt 5. So that PR does not work for you. |
@uilianries Done here: #11857 |
@paulharris Is my latest patch submitted upstream addressing the issue you are raising ? |
Failure in build 15 (
Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability. |
I'll comment in there, it looks ok to me, but I wonder what the cmake experts would say about it. |
cmake expert unfortunately I'm not <(-_-)> |
I think we should wait for the next release of QXlsx because there is too much fix for Qt 6 since the last release: [git log --oneline -- QXlsx/CMakeLists.txt] |
On its way: #12604 |
Specify library name and version: qxlsx/1.4.3
This is also a good place to share with all of us why you are submitting this PR (specially if it is a new addition to ConanCenter): is it a dependency of other libraries you want to package? Are you the author of the library? Thanks!